summary refs log tree commit diff
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2020-03-13 11:32:35 +0100
committerLudovic Courtès <ludo@gnu.org>2020-03-13 17:33:37 +0100
commita0feabdfdb5b0949ac16fc8280bbabe157cbd084 (patch)
tree2ad4a8f3c575f31ee447e4b3ef5f2908f6d5cc6a
parentbe764b47ad1079df531f016c1946cbf98ff48c41 (diff)
downloadguix-a0feabdfdb5b0949ac16fc8280bbabe157cbd084.tar.gz
weather: '--coverage' filters out non-package objects.
This is a followup to d37b5a1b58824dafbe6f32b1c183661c147c660c.

* guix/scripts/weather.scm (guix-weather): Filter PACKAGES passed to
'report-package-coverage'.
-rw-r--r--guix/scripts/weather.scm6
1 files changed, 5 insertions, 1 deletions
diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm
index 913c84955e..a9e0cba92a 100644
--- a/guix/scripts/weather.scm
+++ b/guix/scripts/weather.scm
@@ -552,7 +552,11 @@ SERVER.  Display information for packages with at least THRESHOLD dependents."
                   (match (assoc-ref opts 'coverage)
                     (#f #f)
                     (threshold
-                     (report-package-coverage server packages systems
+                     ;; PACKAGES may include non-package objects coming from a
+                     ;; manifest.  Filter them out.
+                     (report-package-coverage server
+                                              (filter package? packages)
+                                              systems
                                               #:threshold threshold)))
 
                   (= 1 coverage))