summary refs log tree commit diff
diff options
context:
space:
mode:
authorTobias Geerinckx-Rice <me@tobias.gr>2019-06-08 04:14:02 +0200
committerTobias Geerinckx-Rice <me@tobias.gr>2019-08-26 15:56:33 +0200
commitd4d27ddb99280d6d77282ddc2f010c59bff0b665 (patch)
treea2a1dd1aa55d018bcb055a6e71726bbdfcc6183f
parent55c43108ac763c68f95cce3d32c60b8944b771f5 (diff)
downloadguix-d4d27ddb99280d6d77282ddc2f010c59bff0b665.tar.gz
installer: Partition as the last step.
Multiple users have been understandably displeased to find out that
their network card was unsupported, and Internet access mandatory,
after having already formatted their partitions.

* gnu/installer.scm (installer-steps): Run the ‘partition’ step just
before the ‘final’ one.
-rw-r--r--gnu/installer.scm21
1 files changed, 12 insertions, 9 deletions
diff --git a/gnu/installer.scm b/gnu/installer.scm
index 15d971dfc4..167653263f 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2019 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -226,15 +227,6 @@ selected keymap."
                      (#$keymap-step current-installer)))
           (configuration-formatter keyboard-layout->configuration))
 
-         ;; Run a partitioning tool allowing the user to modify
-         ;; partition tables, partitions and their mount points.
-         (installer-step
-          (id 'partition)
-          (description (G_ "Partitioning"))
-          (compute (lambda _
-                     ((installer-partition-page current-installer))))
-          (configuration-formatter user-partitions->configuration))
-
          ;; Ask the user to input a hostname for the system.
          (installer-step
           (id 'hostname)
@@ -267,6 +259,17 @@ selected keymap."
                      ((installer-services-page current-installer))))
 	  (configuration-formatter system-services->configuration))
 
+         ;; Run a partitioning tool allowing the user to modify
+         ;; partition tables, partitions and their mount points.
+         ;; Do this last so the user has something to boot if any
+         ;; of the previous steps didn't go as expected.
+         (installer-step
+          (id 'partition)
+          (description (G_ "Partitioning"))
+          (compute (lambda _
+                     ((installer-partition-page current-installer))))
+          (configuration-formatter user-partitions->configuration))
+
 	 (installer-step
           (id 'final)
           (description (G_ "Configuration file"))