summary refs log tree commit diff
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2019-05-15 12:14:58 +0200
committerLudovic Courtès <ludo@gnu.org>2019-05-15 12:18:51 +0200
commit33572a36624aa1c5cca409cfee36eb67982f4891 (patch)
tree257b649d91630b5dc14cc5ed62b01c54d37f8349
parent8b310793d2b7d3cf5b3a5301423640dcf68e2528 (diff)
downloadguix-33572a36624aa1c5cca409cfee36eb67982f4891.tar.gz
tests: Skip unreliable "herd invalidate nscd" test.
* gnu/tests/base.scm (run-basic-test)["nscd invalidate action, wrong
table"]: Skip unconditionally.
-rw-r--r--gnu/services/base.scm4
-rw-r--r--gnu/tests/base.scm3
2 files changed, 5 insertions, 2 deletions
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 015d873308..f709ca5519 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1294,8 +1294,8 @@ the tty to run, among other things."
                (lambda args
                  ;; There's a race with the SIGCHLD handler, which could
                  ;; call 'waitpid' before 'close-pipe' above does.  If we
-                 ;; get ECHILD, that means we lost the race, but that's
-                 ;; fine.
+                 ;; get ECHILD, that means we lost the race; in that case, we
+                 ;; cannot tell what the exit code was (FIXME).
                  (or (= ECHILD (system-error-errno args))
                      (apply throw args)))))
             (line
diff --git a/gnu/tests/base.scm b/gnu/tests/base.scm
index cf942fe5e1..247f237622 100644
--- a/gnu/tests/base.scm
+++ b/gnu/tests/base.scm
@@ -382,6 +382,9 @@ info --version")
                                                     result)
                              marionette))
 
+          ;; FIXME: The 'invalidate' action can't reliably obtain the exit
+          ;; code of 'nscd' so skip this test.
+          (test-skip 1)
           (test-equal "nscd invalidate action, wrong table"
             '(#f)                                 ;one value, #f
             (marionette-eval '(with-shepherd-action 'nscd ('invalidate "xyz")