summary refs log tree commit diff
path: root/tests
diff options
context:
space:
mode:
authorLudovic Courtès <ludo@gnu.org>2022-08-10 16:37:34 +0200
committerLudovic Courtès <ludo@gnu.org>2022-08-10 16:53:58 +0200
commitebda12e1d2c64480bb7d5977e580d8b2eabeb503 (patch)
tree24a8bc2b129d4865c9489891204d6dcb00f26a13 /tests
parent06ce4e3c06145423e66bb5694d800256e762057c (diff)
downloadguix-ebda12e1d2c64480bb7d5977e580d8b2eabeb503.tar.gz
read-print: Report missing closing parens instead of looping.
Fixes <https://issues.guix.gnu.org/57093>.
Reported by Mohammed AMAR-BENSABER <renken@shione.net>.

Previously 'read-with-comments' would enter an infinite loop.

* guix/read-print.scm (read-with-comments)[missing-closing-paren-error]:
New procedure.
Call it when 'loop' as called from 'liip' returns EOF.
* tests/read-print.scm ("read-with-comments: missing closing paren"):
New test.
Diffstat (limited to 'tests')
-rw-r--r--tests/read-print.scm7
1 files changed, 7 insertions, 0 deletions
diff --git a/tests/read-print.scm b/tests/read-print.scm
index b484e28022..4dabcc1e64 100644
--- a/tests/read-print.scm
+++ b/tests/read-print.scm
@@ -19,6 +19,8 @@
 (define-module (tests-style)
   #:use-module (guix read-print)
   #:use-module (guix gexp)                        ;for the reader extensions
+  #:use-module (srfi srfi-34)
+  #:use-module (srfi srfi-35)
   #:use-module (srfi srfi-64)
   #:use-module (ice-9 match))
 
@@ -46,6 +48,11 @@ expressions."
 
 (test-begin "read-print")
 
+(test-assert "read-with-comments: missing closing paren"
+  (guard (c ((error? c) #t))
+    (call-with-input-string "(what is going on?"
+      read-with-comments)))
+
 (test-equal "read-with-comments: dot notation"
   (cons 'a 'b)
   (call-with-input-string "(a . b)"