From 344316b455345485dfd60baaa88105599467fe9b Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Wed, 10 Mar 2021 13:14:15 +0100 Subject: gnu: xvfb-run: Fix ‘xvfb-run --help’ in a pure environment. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/xorg.scm (xvfb-run)[arguments]: Refer to ‘cat’ by absolute file name, and test whether ‘xvfb-run --help’ succeeds in a pure environment in the ‘check’ phase. Signed-off-by: Mathieu Othacehe --- gnu/packages/xorg.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm index 45001309be..6a7849f8c6 100644 --- a/gnu/packages/xorg.scm +++ b/gnu/packages/xorg.scm @@ -29,6 +29,7 @@ ;;; Copyright © 2021 Nicolò Balzarotti ;;; Copyright © 2021 Matthew James Kraai ;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -6878,7 +6879,7 @@ box, and a calendar. It uses GTK+, and will match your desktop theme.") (lambda _ (chmod "xvfb-run" #o755) (substitute* "xvfb-run" - (("(\\(| )(fmt|stty|awk|kill|getopt|mktemp|touch|rm|mcookie)" + (("(\\(| )(fmt|stty|awk|cat|kill|getopt|mktemp|touch|rm|mcookie)" _ prefix command) (string-append prefix (which command))) ;; These also feature in UI messages, so be more strict. @@ -6887,13 +6888,15 @@ box, and a calendar. It uses GTK+, and will match your desktop theme.") (string-append prefix (which command)))))) (replace 'check ;; There are no tests included. Here we test whether we can run - ;; a simple client without xvfb-run itself relying on $PATH. + ;; a simple client and whether xvfb-run --help succeeds + ;; without xvfb-run itself relying on $PATH. (lambda* (#:key tests? #:allow-other-keys) (when tests? (let ((old-PATH (getenv "PATH")) (xterm (which "xterm"))) (unsetenv "PATH") (invoke "./xvfb-run" xterm "-e" "true") + (invoke "./xvfb-run" "--help") (setenv "PATH" old-PATH))))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- cgit 1.4.1