From 5cc5364ebad7f72afe0213b0a58997c195722a0a Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Thu, 13 Jun 2019 02:17:48 +0200 Subject: gnu: dstat: Add python2-six. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/admin.scm (dstat)[inputs]: Add python2-six. [arguments]: Add ‘wrap’ phase to make dstat find required modules. --- gnu/packages/admin.scm | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'gnu/packages/admin.scm') diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index d85bd6e324..9392c59521 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2140,9 +2140,20 @@ results (ndiff), and a packet generation and response analysis tool (nping).") #:make-flags (let ((out (assoc-ref %outputs "out"))) (list (string-append "DESTDIR=" out) "prefix=/")) - ;; No configure script. - #:phases (modify-phases %standard-phases (delete 'configure)))) - (inputs `(("python-2" ,python-2))) + #:phases + (modify-phases %standard-phases + (delete 'configure) ; no configure script + (add-after 'install 'wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (wrap-program (string-append out "/bin/dstat") + `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))) + #t)))))) + (inputs + ;; Python 3 is supposedly supported but prints a DeprecationWarning. + ;; Upstream is dead. See . + `(("python" ,python-wrapper) + ("python-six" ,python-six))) (synopsis "Versatile resource statistics tool") (description "Dstat is a versatile replacement for @command{vmstat}, @command{iostat}, @command{netstat}, and @command{ifstat}. Dstat overcomes -- cgit 1.4.1 From fa67073f13a889589b4b0207e83891fe9226f2dc Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sun, 16 Jun 2019 02:58:43 +0200 Subject: gnu: dstat: Fix Python 3 deprecation warning. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/admin.scm (dstat)[arguments]: Add ‘fix-python3-DeprecationWarning’ phase. --- gnu/packages/admin.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'gnu/packages/admin.scm') diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 9392c59521..a897afdc0e 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2142,6 +2142,11 @@ results (ndiff), and a packet generation and response analysis tool (nping).") "prefix=/")) #:phases (modify-phases %standard-phases + (add-after 'unpack 'fix-python3-DeprecationWarning + (lambda _ + (substitute* "dstat" + (("collections") "collections.abc")) + #t)) (delete 'configure) ; no configure script (add-after 'install 'wrap (lambda* (#:key outputs #:allow-other-keys) @@ -2150,8 +2155,6 @@ results (ndiff), and a packet generation and response analysis tool (nping).") `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))) #t)))))) (inputs - ;; Python 3 is supposedly supported but prints a DeprecationWarning. - ;; Upstream is dead. See . `(("python" ,python-wrapper) ("python-six" ,python-six))) (synopsis "Versatile resource statistics tool") -- cgit 1.4.1 From 10a32973893f5229c963241b6339ecab05b6098e Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Sun, 16 Jun 2019 03:00:29 +0200 Subject: gnu: dstat: Add two patches, fix two bugs. * gnu/packages/admin.scm (dstat)[source]: Add patches. * gnu/packages/patches/dstat-fix-crash-when-specifying-delay.patch, gnu/packages/patches/dstat-skip-devices-without-io.patch: New files. * gnu/local.mk (dist_patch_DATA): Add them. --- gnu/local.mk | 2 + gnu/packages/admin.scm | 4 +- .../dstat-fix-crash-when-specifying-delay.patch | 48 ++++++++++++++++++++++ .../patches/dstat-skip-devices-without-io.patch | 32 +++++++++++++++ 4 files changed, 85 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/dstat-fix-crash-when-specifying-delay.patch create mode 100644 gnu/packages/patches/dstat-skip-devices-without-io.patch (limited to 'gnu/packages/admin.scm') diff --git a/gnu/local.mk b/gnu/local.mk index 5b6dd31b11..da3245ea18 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -753,6 +753,8 @@ dist_patch_DATA = \ %D%/packages/patches/docker-use-fewer-modprobes.patch \ %D%/packages/patches/dovecot-trees-support-dovecot-2.3.patch \ %D%/packages/patches/doxygen-test.patch \ + %D%/packages/patches/dstat-fix-crash-when-specifying-delay.patch \ + %D%/packages/patches/dstat-skip-devices-without-io.patch \ %D%/packages/patches/dvd+rw-tools-add-include.patch \ %D%/packages/patches/elfutils-tests-ptrace.patch \ %D%/packages/patches/elixir-path-length.patch \ diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index a897afdc0e..4ae0733fbb 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2133,7 +2133,9 @@ results (ndiff), and a packet generation and response analysis tool (nping).") (commit (string-append "v" version)))) (file-name (git-file-name "dstat" version)) (sha256 - (base32 "1qnmkhqmjd1m3if05jj29dvr5hn6kayq9bkkkh881w472c0zhp8v")))) + (base32 "1qnmkhqmjd1m3if05jj29dvr5hn6kayq9bkkkh881w472c0zhp8v")) + (patches (search-patches "dstat-fix-crash-when-specifying-delay.patch" + "dstat-skip-devices-without-io.patch")))) (build-system gnu-build-system) (arguments `(#:tests? #f ; no make check diff --git a/gnu/packages/patches/dstat-fix-crash-when-specifying-delay.patch b/gnu/packages/patches/dstat-fix-crash-when-specifying-delay.patch new file mode 100644 index 0000000000..0b59387dc9 --- /dev/null +++ b/gnu/packages/patches/dstat-fix-crash-when-specifying-delay.patch @@ -0,0 +1,48 @@ +From: Tobias Geerinckx-Rice +Date: Sun, 16 Jun 2019 02:34:10 +0200 +Subject: [PATCH] gnu: dstat: Fix crash when specifying a delay. + +Taken verbatim from a pull request[0] that will never be merged. + +[0]: https://github.com/dagwieers/dstat/pull/167 + +From 220a785321b13b6df92a536080aca6ef1cb644ad Mon Sep 17 00:00:00 2001 +From: Falko Goettsch +Date: Mon, 11 Mar 2019 20:12:49 -0700 +Subject: [PATCH] Fixed bug when specifying a delay + +The division in the 'loop' calculation in perform() was returning floating point values +after the migration to Python 3, rather than rounding down. Changed to floor division. + +I think the floating point values kept 'loop == 0' from ever being +true and the variables inside that conditional were never initialized, +causing the following error when a delay other than 1 was specified: + +You did not select any stats, using -cdngy by default. +Traceback (most recent call last): + File "/home/falko/repos/dstat/dstat", line 2825, in + main() + File "/home/falko/repos/dstat/dstat", line 2684, in main + scheduler.run() + File "/home/falko/.conda/envs/python3/lib/python3.7/sched.py", line 151, in run + action(*argument, **kwargs) + File "/home/falko/repos/dstat/dstat", line 2729, in perform + oldcols = cols +NameError: name 'cols' is not defined +--- + dstat | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/dstat b/dstat +index 9359965..3b4980f 100755 +--- a/dstat ++++ b/dstat +@@ -2697,7 +2697,7 @@ def perform(update): + + starttime = time.time() + +- loop = (update - 1 + op.delay) / op.delay ++ loop = (update - 1 + op.delay) // op.delay + step = ((update - 1) % op.delay) + 1 + + ### Get current time (may be different from schedule) for debugging diff --git a/gnu/packages/patches/dstat-skip-devices-without-io.patch b/gnu/packages/patches/dstat-skip-devices-without-io.patch new file mode 100644 index 0000000000..eb0910f501 --- /dev/null +++ b/gnu/packages/patches/dstat-skip-devices-without-io.patch @@ -0,0 +1,32 @@ +From: Tobias Geerinckx-Rice +Date: Sun, 16 Jun 2019 02:36:23 +0200 +Subject: [PATCH] gnu: dstat: Skip devices without I/O. + +Taken verbatim from a pull request[0] that will never be merged. + +[0]: https://github.com/dagwieers/dstat/pull/164 + +From 0988589ea4ee092b285bd4049d56add5f61e3f69 Mon Sep 17 00:00:00 2001 +From: Tobias Gruetzmacher +Date: Fri, 15 Feb 2019 18:46:57 +0100 +Subject: [PATCH] Skip devices without I/O + +Linux 4.18+ has added more fields to the diskstats proc file, so the +original skip condition for devices without I/O didn't apply anymore. +--- + dstat | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/dstat b/dstat +index 9359965..5c2fb53 100755 +--- a/dstat ++++ b/dstat +@@ -763,7 +763,7 @@ class dstat_disk(dstat): + ret = [] + for l in self.splitlines(): + if len(l) < 13: continue +- if l[3:] == ['0',] * 11: continue ++ if l[3:] == ['0',] * (len(l) - 3): continue + name = l[2] + ret.append(name) + for item in objlist: ret.append(item) -- cgit 1.4.1 From a6dc3cc197955708e16516926addbf5a617efee9 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Wed, 19 Jun 2019 17:03:13 +0200 Subject: gnu: ansible: Update to 2.8.1. * gnu/packages/admin.scm (ansible): Update to 2.8.1. --- gnu/packages/admin.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gnu/packages/admin.scm') diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 4ae0733fbb..fa1591a8ec 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -1734,13 +1734,13 @@ of supported upstream metrics systems simultaneously.") (define-public ansible (package (name "ansible") - (version "2.8.0") + (version "2.8.1") (source (origin (method url-fetch) (uri (pypi-uri "ansible" version)) (sha256 - (base32 "1bpk5r5x6vdgn839n74yv2chd2ja10yfrhav0fzwa38mi5yxsd3j")))) + (base32 "0ia4x17ywym3r1m96ar4h0wc2xlylhbjp6x4wzwkh4p2i0x1vmg1")))) (build-system python-build-system) (native-inputs `(("python-bcrypt" ,python-bcrypt) -- cgit 1.4.1 From bb3dc8025a7c98e95aa8a13537fb89ad3944685b Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Wed, 19 Jun 2019 17:15:49 +0200 Subject: gnu: shadow: Update to 4.7. * gnu/packages/admin.scm (shadow): Update to 4.7. --- gnu/packages/admin.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gnu/packages/admin.scm') diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index fa1591a8ec..6b4d657657 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -438,7 +438,7 @@ hostname.") (define-public shadow (package (name "shadow") - (version "4.6") + (version "4.7") (source (origin (method url-fetch) (uri (string-append @@ -446,7 +446,7 @@ hostname.") "download/" version "/shadow-" version ".tar.xz")) (sha256 (base32 - "10smy01km2bqjjvsd2jz17zvrxbzj89qczyb1amk38j28bcci609")))) + "0v71474rx38lg9kidrm4xbk35sg3icv3s5pk2b42icp3lyj9dqg5")))) (build-system gnu-build-system) (arguments `(;; Assume System V `setpgrp (void)', which is the default on GNU -- cgit 1.4.1 From 1f6dd7e9c2b1feb6339ed4eb8070e905a3afe9a6 Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Wed, 19 Jun 2019 17:16:46 +0200 Subject: gnu: shadow: Update home page. * gnu/packages/admin.scm (shadow)[home-page]: Update to new project home. --- gnu/packages/admin.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gnu/packages/admin.scm') diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 6b4d657657..c6ed4c6d4a 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -482,7 +482,7 @@ hostname.") "-linux") `(("linux-pam" ,linux-pam)) '())) - (home-page "http://pkg-shadow.alioth.debian.org/") + (home-page "https://github.com/shadow-maint/shadow") (synopsis "Authentication-related tools such as passwd, su, and login") (description "Shadow provides a number of authentication-related tools, including: -- cgit 1.4.1