From 9a224ac2e37482cb69c2803648bf3c66fbc6eee9 Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Sat, 27 Dec 2014 08:34:43 -0500 Subject: gnu: Use patch --force instead of --batch. * gnu/packages/linux.scm (linux-libre, net-tools): Pass "--force" to patch, instead of "--batch". * gnu/packages/mit-krb5.scm (mit-krb5): Ditto. --- gnu/packages/linux.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gnu/packages/linux.scm') diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index a2708a290f..9dc5f5cd40 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -196,7 +196,7 @@ for SYSTEM, or #f if there is no configuration for SYSTEM." (build-phase '(lambda* (#:key system inputs #:allow-other-keys #:rest args) ;; Apply the neat patch. - (system* "patch" "-p1" "--batch" + (system* "patch" "-p1" "--force" "-i" (assoc-ref inputs "patch/freedo+gnu")) (let ((arch (car (string-split system #\-)))) @@ -774,7 +774,7 @@ manpages.") 'unpack 'patch (lambda* (#:key inputs #:allow-other-keys) (define (apply-patch file) - (zero? (system* "patch" "-p1" "--batch" + (zero? (system* "patch" "-p1" "--force" "--input" file))) (let ((patch.gz (assoc-ref inputs "patch"))) -- cgit 1.4.1 From 856ae5e6c71a1283a414d33e638051f95d3cce35 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Sat, 27 Dec 2014 19:20:18 +0100 Subject: build-system/gnu: Strip with '--strip-all' instead of '--strip-debug'. This saves 19% on the 'bin' directory of Coreutils, and certainly helpful for things like Git's 'libexec' directory. * guix/build-system/gnu.scm (gnu-build): Change default value for #:strip-flags to '("--strip-all"). * guix/build/gnu-build-system.scm (strip): Ditto. * gnu/packages/linux.scm (linux-libre)[arguments]: Add #:strip-flags. --- gnu/packages/linux.scm | 5 +++++ guix/build-system/gnu.scm | 2 +- guix/build/gnu-build-system.scm | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) (limited to 'gnu/packages/linux.scm') diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 9dc5f5cd40..53368251b5 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -292,6 +292,11 @@ for SYSTEM, or #f if there is no configuration for SYSTEM." (alist-replace 'install ,install-phase (alist-delete 'configure %standard-phases))) + + ;; Use '--strip-debug', not '--strip-all', because the latter leads to + ;; unloadable modules (due to the lack of a symbol table.) + #:strip-flags '("--strip-debug") + #:tests? #f)) (synopsis "100% free redistribution of a cleaned Linux kernel") (description diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm index c675155a6a..f765a144c4 100644 --- a/guix/build-system/gnu.scm +++ b/guix/build-system/gnu.scm @@ -274,7 +274,7 @@ standard packages used as implicit inputs of the GNU build system." (parallel-tests? #t) (patch-shebangs? #t) (strip-binaries? #t) - (strip-flags ''("--strip-debug")) + (strip-flags ''("--strip-all")) (strip-directories ''("lib" "lib64" "libexec" "bin" "sbin")) (phases '%standard-phases) diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index 4cc755f3a6..d661736831 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -295,7 +295,7 @@ makefiles." (objcopy-command (if target (string-append target "-objcopy") "objcopy")) - (strip-flags '("--strip-debug")) + (strip-flags '("--strip-all")) (strip-directories '("lib" "lib64" "libexec" "bin" "sbin")) #:allow-other-keys) -- cgit 1.4.1 From 7da473b75721e06237b106c6d186f2729117b1ee Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Mon, 29 Dec 2014 21:44:48 +0100 Subject: gnu: Revert use of '--strip-all'. This reverts commits f05bdc9412135f34a1c417edc203c35cd005d0d5 and 856ae5e6c71a1283a414d33e638051f95d3cce35. This broke all sorts of things. See , for example. --- gnu/packages/base.scm | 3 --- gnu/packages/commencement.scm | 4 ---- gnu/packages/linux.scm | 5 ----- guix/build-system/gnu.scm | 4 +--- guix/build/gnu-build-system.scm | 13 ++----------- 5 files changed, 3 insertions(+), 26 deletions(-) (limited to 'gnu/packages/linux.scm') diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index b4f4d8ee06..5bf27c9ef1 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -421,9 +421,6 @@ included.") ;; XXX: Work around "undefined reference to `__stack_chk_guard'". "libc_cv_ssp=no") - ;; Using '--strip-all' on crt*.o breaks them. - #:strip-flags '("--strip-debug") - #:tests? #f ; XXX #:phases (alist-cons-before 'configure 'pre-configure diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 309e195bc2..20831de997 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -170,10 +170,6 @@ identifier SYSTEM." (ice-9 regex) (srfi srfi-1) (srfi srfi-26)) - - ;; Using '--strip-all' leads to a link failure while building libc. - #:strip-flags '("--strip-debug") - ,@(substitute-keyword-arguments (package-arguments gcc-4.8) ((#:configure-flags flags) `(append (list ,(string-append "--target=" (boot-triplet)) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 53368251b5..9dc5f5cd40 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -292,11 +292,6 @@ for SYSTEM, or #f if there is no configuration for SYSTEM." (alist-replace 'install ,install-phase (alist-delete 'configure %standard-phases))) - - ;; Use '--strip-debug', not '--strip-all', because the latter leads to - ;; unloadable modules (due to the lack of a symbol table.) - #:strip-flags '("--strip-debug") - #:tests? #f)) (synopsis "100% free redistribution of a cleaned Linux kernel") (description diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm index e2b41b1898..c675155a6a 100644 --- a/guix/build-system/gnu.scm +++ b/guix/build-system/gnu.scm @@ -274,8 +274,7 @@ standard packages used as implicit inputs of the GNU build system." (parallel-tests? #t) (patch-shebangs? #t) (strip-binaries? #t) - (strip-flags ''("--strip-all")) - (archive-strip-flags ''("--strip-debug")) + (strip-flags ''("--strip-debug")) (strip-directories ''("lib" "lib64" "libexec" "bin" "sbin")) (phases '%standard-phases) @@ -339,7 +338,6 @@ are allowed to refer to." #:patch-shebangs? ,patch-shebangs? #:strip-binaries? ,strip-binaries? #:strip-flags ,strip-flags - #:archive-strip-flags ,archive-strip-flags #:strip-directories ,strip-directories))) (define guile-for-build diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index a985b1c715..1311cdcc9a 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -297,13 +297,7 @@ makefiles." (objcopy-command (if target (string-append target "-objcopy") "objcopy")) - (strip-flags '("--strip-all")) - - ;; Using '--strip-all' on .a file would remove the archive - ;; index, leading to "Archive has no index" errors when - ;; linking against them. - (archive-strip-flags '("--strip-debug")) - + (strip-flags '("--strip-debug")) (strip-directories '("lib" "lib64" "libexec" "bin" "sbin")) #:allow-other-keys) @@ -359,10 +353,7 @@ makefiles." (or (not debug-output) (make-debug-file path)) (zero? (apply system* strip-command - (append (if (ar-file? path) - archive-strip-flags - strip-flags) - (list path)))) + (append strip-flags (list path)))) (or (not debug-output) (add-debug-link path)))) (const #t) ; down -- cgit 1.4.1 From 8fcaf8b173a6d0ce3d6f58f9052fdd085911912f Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Tue, 6 Jan 2015 13:52:57 -0500 Subject: gnu: lvm2: Switch to eudev from udev. * gnu/packages/linux.scm (lvm2)[inputs]: Use eudev, not udev. --- gnu/packages/linux.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gnu/packages/linux.scm') diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 9dc5f5cd40..d5c7ffdcba 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -2,7 +2,7 @@ ;;; Copyright © 2012, 2013, 2014 Ludovic Courtès ;;; Copyright © 2013, 2014 Andreas Enge ;;; Copyright © 2012 Nikita Karetnikov -;;; Copyright © 2014 Mark H Weaver +;;; Copyright © 2014, 2015 Mark H Weaver ;;; ;;; This file is part of GNU Guix. ;;; @@ -1439,7 +1439,7 @@ time.") `(("pkg-config" ,pkg-config) ("procps" ,procps))) ;tests use 'pgrep' (inputs - `(("udev" ,udev))) + `(("udev" ,eudev))) (arguments '(#:phases (alist-cons-after 'configure 'set-makefile-shell -- cgit 1.4.1 From fe32c7f760ba9a8082eecd0fa0136f71dced032b Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Tue, 6 Jan 2015 14:02:08 -0500 Subject: gnu: udev: Remove package, now superceded by eudev. * gnu/packages/linux.scm (udev): Remove. (eudev): Incorporate fields formerly inherited from udev. --- gnu/packages/linux.scm | 84 ++++++++++++++++++++------------------------------ 1 file changed, 33 insertions(+), 51 deletions(-) (limited to 'gnu/packages/linux.scm') diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index d5c7ffdcba..00ac4d893a 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -1337,55 +1337,9 @@ kmod. The aim is to be compatible with tools, configurations and indices from the module-init-tools project.") (license gpl2+))) ; library under lgpl2.1+ -(define-public udev - ;; The last pre-systemd version. - (package - (name "udev") - (version "182") - (source (origin - (method url-fetch) - (uri (string-append - "mirror://kernel.org/linux/utils/kernel/hotplug/udev-" - version ".tar.xz")) - (sha256 - (base32 - "1awp7p07gi083w0dwqhhbbas68a7fx2sbm1yf1ip2jwf7cpqkf5d")) - (patches (list (search-patch "udev-gir-libtool.patch"))))) - (build-system gnu-build-system) - (arguments - `(#:configure-flags (list (string-append - "--with-pci-ids-path=" - (assoc-ref %build-inputs "pciutils") - "/share/pci.ids.gz") - - "--with-firmware-path=/no/firmware" - - ;; Work around undefined reference to - ;; 'mq_getattr' in sc-daemon.c. - "LDFLAGS=-lrt"))) - (native-inputs - `(("pkg-config" ,pkg-config) - ("gperf" ,gperf) - ("glib" ,glib "bin") ; glib-genmarshal, etc. - ("perl" ,perl) ; for the tests - ("python" ,python-2))) ; ditto - (inputs - `(("kmod" ,kmod) - ("pciutils" ,pciutils) - ("usbutils" ,usbutils) - ("util-linux" ,util-linux) - ("glib" ,glib) - ("gobject-introspection" ,gobject-introspection))) - (home-page "http://www.freedesktop.org/software/systemd/libudev/") - (synopsis "Userspace device management") - (description "Udev is a daemon which dynamically creates and removes -device nodes from /dev/, handles hotplug events and loads drivers at boot -time.") - (license gpl2+))) ; libudev is under lgpl2.1+ - (define-public eudev ;; The post-systemd fork, maintained by Gentoo. - (package (inherit udev) + (package (name "eudev") (version "1.10") (source (origin @@ -1406,11 +1360,39 @@ time.") '(substitute* "configure" (("linux/btrfs\\.h") ""))))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config) + ("gperf" ,gperf) + ("glib" ,glib "bin") ; glib-genmarshal, etc. + ("perl" ,perl) ; for the tests + ("python" ,python-2))) ; ditto + (inputs + `(("kmod" ,kmod) + ("pciutils" ,pciutils) + ("usbutils" ,usbutils) + ("util-linux" ,util-linux) + ("glib" ,glib) + ("gobject-introspection" ,gobject-introspection))) (arguments - (substitute-keyword-arguments (package-arguments udev) - ((#:configure-flags flags) - `(cons "--enable-libkmod" ,flags)))) - (home-page "http://www.gentoo.org/proj/en/eudev/"))) + `(#:configure-flags (list "--enable-libkmod" + + (string-append + "--with-pci-ids-path=" + (assoc-ref %build-inputs "pciutils") + "/share/pci.ids.gz") + + "--with-firmware-path=/no/firmware" + + ;; Work around undefined reference to + ;; 'mq_getattr' in sc-daemon.c. + "LDFLAGS=-lrt"))) + (home-page "http://www.gentoo.org/proj/en/eudev/") + (synopsis "Userspace device management") + (description "Udev is a daemon which dynamically creates and removes +device nodes from /dev/, handles hotplug events and loads drivers at boot +time.") + (license gpl2+))) (define-public lvm2 (package -- cgit 1.4.1