From de409e82261eb147b6614aef8731d795ca664ef0 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Sat, 29 Dec 2018 21:42:03 -0500 Subject: services: gdm: Remove 'allow-root?' option. This option results in allowing all login attempts without asking for credentials. The name is confusing, but rather than rename it, we will remove it, since it seems like a feature that no one would want. * gnu/services/xorg.scm (): Remove 'allow-root?'. (gdm-pam-service): Do not use 'gdm-configuration-allow-root?'. Signed-off-by: Danny Milosavljevic --- gnu/services/xorg.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'gnu/services') diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index ea8433af3a..48aa8f68cc 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2017 Andy Wingo ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2018 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -625,7 +626,6 @@ makes the good ol' XlockMore usable." gdm-configuration? (gdm gdm-configuration-gdm (default gdm)) (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) - (allow-root? gdm-configuration-allow-root? (default #t)) (auto-login? gdm-configuration-auto-login? (default #f)) (default-user gdm-configuration-default-user (default #f)) (x-server gdm-configuration-x-server)) @@ -680,10 +680,9 @@ makes the good ol' XlockMore usable." (auth (list (pam-entry (control "required") (module "pam_permit.so"))))) - (unix-pam-service - "gdm-password" - #:allow-empty-passwords? (gdm-configuration-allow-empty-passwords? config) - #:allow-root? (gdm-configuration-allow-root? config)))) + (unix-pam-service "gdm-password" + #:allow-empty-passwords? + (gdm-configuration-allow-empty-passwords? config)))) (define (gdm-shepherd-service config) (list (shepherd-service -- cgit 1.4.1 From 48c8d067d4ded776939cda6f9c63c25b38ba77fc Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Sat, 29 Dec 2018 21:42:04 -0500 Subject: services: gdm: Enable auto-start. GDM is now reliable enough to run automatically. * gnu/services/xorg.scm (gdm-shepherd-service): Do not set 'auto-start?' to '#f'. Signed-off-by: Danny Milosavljevic --- gnu/services/xorg.scm | 2 -- 1 file changed, 2 deletions(-) (limited to 'gnu/services') diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 48aa8f68cc..b3c24746d1 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -689,8 +689,6 @@ makes the good ol' XlockMore usable." (documentation "Xorg display server (GDM)") (provision '(xorg-server)) (requirement '(dbus-system user-processes host-name udev)) - ;; While this service isn't working properly, turn off auto-start. - (auto-start? #f) (start #~(lambda () (fork+exec-command (list #$(file-append (gdm-configuration-gdm config) -- cgit 1.4.1