about summary refs log tree commit diff homepage
diff options
context:
space:
mode:
authorDan Liew <daniel.liew@imperial.ac.uk>2014-01-29 19:50:26 +0000
committerDan Liew <daniel.liew@imperial.ac.uk>2014-01-29 19:55:53 +0000
commitb560d56fe4963583956872f4e807b9f32d46887d (patch)
tree4e873bff9488346594af442b3eea17b09c67b086
parente49c1e1958e863195b01d99c92194289b4034bbb (diff)
downloadklee-b560d56fe4963583956872f4e807b9f32d46887d.tar.gz
Fix Runtime/POSIX/Isatty.c test under LLVM3.3. The program makes
a call fprintf(stderr,...). llvm-gcc transforms this to a call to
fwrite() however clang does not so klee-uclibc's fprintf will be
called instead and if klee-uclibc is compiled with KLEE_SYM_PRINTF
then output will always go stdout if the FILE is stdout or stderr.

The end result of this is that when we build with Clang under LLVM3.3
is that the fprintf(stderr,...) print outs go to standard output instead
and so the test would fail because it expects the fprintf(stderr,...)
to be on stderr.

This test sort of fixes this by having the test check stdout for
the fprintf(stderr,...) statements too.
-rw-r--r--test/Runtime/POSIX/Isatty.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/Runtime/POSIX/Isatty.c b/test/Runtime/POSIX/Isatty.c
index bd514d48..3054aadb 100644
--- a/test/Runtime/POSIX/Isatty.c
+++ b/test/Runtime/POSIX/Isatty.c
@@ -1,5 +1,5 @@
 // RUN: %llvmgcc %s -emit-llvm -O0 -c -o %t.bc
-// RUN: %klee --libc=uclibc --posix-runtime %t.bc --sym-files 0 10 --sym-stdout 2>%t.log
+// RUN: %klee --libc=uclibc --posix-runtime %t.bc --sym-files 0 10 --sym-stdout > %t.log 2>&1
 // RUN: test -f %T/klee-last/test000001.ktest
 // RUN: test -f %T/klee-last/test000002.ktest
 // RUN: test -f %T/klee-last/test000003.ktest
@@ -10,7 +10,7 @@
 // RUN: grep -q "stdout is NOT a tty" %t.log
 
 // Depending on how uClibc is compiled (i.e. without -DKLEE_SYM_PRINTF)
-// fprintf prints out on stdout even stderr is provided.
+// fprintf prints out on stdout even if stderr is provided.
 #include <unistd.h>
 #include <stdio.h>
 #include <assert.h>