Fix bug in implementation of `NotExpr`. It should not implement

`compareContents()`.

This bug would not have affected correctness but it would have
affected performance because if `Expr::compare()` was called on
two structually equal `NotExpr` then its children would be
checked for structually equality twice - once in
NotExpr::compareContents()` and once in `Expr::compare()`.

This partially addresses #515 .

1 files changed, 0 insertions, 6 deletions

diff --git a/include/klee/Expr.h b/include/klee/Expr.h
index d70cfdc9..500d7d46 100644
--- a/include/klee/Expr.h
+++ b/include/klee/Expr.h
@@ -765,12 +765,6 @@ public:
   unsigned getNumKids() const { return numKids; }
   ref<Expr> getKid(unsigned i) const { return expr; }
 
-  int compareContents(const Expr &b) const {
-    const NotExpr &eb = static_cast<const NotExpr&>(b);
-    if (expr != eb.expr) return expr < eb.expr ? -1 : 1;
-    return 0;
-  }
-
   virtual ref<Expr> rebuild(ref<Expr> kids[]) const { 
     return create(kids[0]);
   }