about summary refs log tree commit diff homepage
path: root/lib/Core/Memory.h
diff options
context:
space:
mode:
authorMartin Nowack <martin.nowack@gmail.com>2018-05-05 00:04:13 +0100
committerCristian Cadar <c.cadar@imperial.ac.uk>2018-05-05 10:35:28 +0100
commitab03c1cdce90660dcb75d000ebda817ae589aaec (patch)
tree7d884b530e8940bc0de8d3227ac944d3798282bb /lib/Core/Memory.h
parent4211cea27f1903f68c2b32267eb34cb95c24b9f3 (diff)
downloadklee-ab03c1cdce90660dcb75d000ebda817ae589aaec.tar.gz
Fix handling of errno if external functions are invoked
If an external function in KLEE is invoked, it might update errno.
Previously, the errno specific variable in a state was only updated
if it was part of the executed instructions.
That opened up a timeframe that increased the likelihood of errno being
overwritten by another method call.

This patch fixes two issues:
* the errno of the KLEE process state is updated before the external
function call allowing to detect changes to it later on
* after the external call, the memory object of errno is directly
updated
with its new value, reducing the likelihood to be overwritten by
another
call

Additional features:
* Add support for `errno()` for Darwin as well.
* Simplified errno handling in POSIX layer
Diffstat (limited to 'lib/Core/Memory.h')
-rw-r--r--lib/Core/Memory.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/Core/Memory.h b/lib/Core/Memory.h
index 3084cf32..e854502c 100644
--- a/lib/Core/Memory.h
+++ b/lib/Core/Memory.h
@@ -154,6 +154,7 @@ private:
   const MemoryObject *object;
 
   uint8_t *concreteStore;
+
   // XXX cleanup name of flushMask (its backwards or something)
   BitArray *concreteMask;