diff options
| -rw-r--r-- | .github/pull_request_template.md | 2 | ||||
| -rw-r--r-- | Dockerfile | 2 | ||||
| -rw-r--r-- | scripts/build/d-klee-linux-ubuntu.inc | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c69cd241..86cf67e9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,5 +8,5 @@ To help expedite the review please ensure the following, by adding an "x" for ea - [ ] Each commit has a meaningful message documenting what it does. - [ ] The code is commented. In particular, newly added classes and functions should be documented. - [ ] The patch is formatted via [clang-format](https://clang.llvm.org/docs/ClangFormat.html) (see also [git-clang-format](https://raw.githubusercontent.com/llvm/llvm-project/master/clang/tools/clang-format/git-clang-format) for Git integration). Please only format the patch itself and code surrounding the patch, not entire files. Divergences from clang-formatting are only rarely accepted, and only if they clearly improve code readability. -- [ ] Add test cases exercising the code you added or modified. We expect [system and/or unit test cases](https://klee.github.io/docs/developers-guide/#regression-testing-framework) for all non-trivial changes. After you submit your PR, you will be able to see a [Codecov report](https://docs.codecov.io/docs/pull-request-comments) telling you which parts of your patch are not covered by the regression test suite. You will also be able to see if the Travis CI and Cirrus CI tests have passed. If they don't, you should examine the failures and address them before the PR can be reviewed. +- [ ] Add test cases exercising the code you added or modified. We expect [system and/or unit test cases](https://klee.github.io/docs/developers-guide/#regression-testing-framework) for all non-trivial changes. After you submit your PR, you will be able to see a [Codecov report](https://docs.codecov.io/docs/pull-request-comments) telling you which parts of your patch are not covered by the regression test suite. You will also be able to see if the Github Actions CI and Cirrus CI tests have passed. If they don't, you should examine the failures and address them before the PR can be reviewed. - [ ] Spellcheck all messages added to the codebase, all comments, as well as commit messages. diff --git a/Dockerfile b/Dockerfile index 6a0eefb9..f01efe6b 100644 --- a/Dockerfile +++ b/Dockerfile @@ -36,7 +36,7 @@ LABEL maintainer="KLEE Developers" # TODO remove adding sudo package # Create ``klee`` user for container with password ``klee``. -# and give it password-less sudo access (temporarily so we can use the TravisCI scripts) +# and give it password-less sudo access (temporarily so we can use the CI scripts) RUN apt update && DEBIAN_FRONTEND=noninteractive apt -y --no-install-recommends install sudo emacs-nox vim-nox file python3-dateutil doxygen && \ rm -rf /var/lib/apt/lists/* && \ useradd -m klee && \ diff --git a/scripts/build/d-klee-linux-ubuntu.inc b/scripts/build/d-klee-linux-ubuntu.inc index fc783cb2..16db5cdf 100644 --- a/scripts/build/d-klee-linux-ubuntu.inc +++ b/scripts/build/d-klee-linux-ubuntu.inc @@ -1,6 +1,6 @@ # TODO remove adding sudo package # Create ``klee`` user for container with password ``klee``. -# and give it password-less sudo access (temporarily so we can use the TravisCI scripts) +# and give it password-less sudo access (temporarily so we can use the CI scripts) RUN apt update && DEBIAN_FRONTEND=noninteractive apt -y --no-install-recommends install sudo emacs-nox vim-nox file python3-dateutil && \ rm -rf /var/lib/apt/lists/* && \ useradd -m klee && \ |