From dff4069042e6f7b4bc7211b8e9ba3377ee01c33c Mon Sep 17 00:00:00 2001 From: Sean Bartell Date: Tue, 28 Apr 2015 20:21:10 -0500 Subject: Fix assertion failure in getDirectCallTarget It failed when the function being called is a bitcasted alias. --- lib/Module/ModuleUtil.cpp | 2 +- test/Feature/BitcastAliasMD2U.ll | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 test/Feature/BitcastAliasMD2U.ll diff --git a/lib/Module/ModuleUtil.cpp b/lib/Module/ModuleUtil.cpp index 5f7ed35e..1cf9c35c 100644 --- a/lib/Module/ModuleUtil.cpp +++ b/lib/Module/ModuleUtil.cpp @@ -446,7 +446,7 @@ Function *klee::getDirectCallTarget(CallSite cs) { return f; } else if (llvm::ConstantExpr *ce = dyn_cast(v)) { if (ce->getOpcode()==Instruction::BitCast) - if (Function *f = dyn_cast(ce->getOperand(0))) + if (Function *f = dyn_cast(ce->getOperand(0)->stripPointerCasts())) return f; // NOTE: This assert may fire, it isn't necessarily a problem and diff --git a/test/Feature/BitcastAliasMD2U.ll b/test/Feature/BitcastAliasMD2U.ll new file mode 100644 index 00000000..24eabaa5 --- /dev/null +++ b/test/Feature/BitcastAliasMD2U.ll @@ -0,0 +1,34 @@ +; RUN: llvm-as %s -f -o %t1.bc +; RUN: rm -rf %t.klee-out +; RUN: %klee --output-dir=%t.klee-out -disable-opt -search=nurs:md2u %t1.bc > %t2 +; RUN: grep PASS %t2 + +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" +target triple = "x86_64-unknown-linux-gnu" + +@foo = alias i32 (i32)* @__foo + +define i32 @__foo(i32 %i) nounwind { +entry: + ret i32 %i +} + +declare i32 @puts(i8*) + +@.passstr = private constant [5 x i8] c"PASS\00", align 1 +@.failstr = private constant [5 x i8] c"FAIL\00", align 1 + +define i32 @main(i32 %argc, i8** nocapture %argv) nounwind readnone { +entry: + %call = call i32 (i64)* bitcast (i32 (i32)* @foo to i32 (i64)*)(i64 52) + %r = icmp eq i32 %call, 52 + br i1 %r, label %bbtrue, label %bbfalse + +bbtrue: + %0 = call i32 @puts(i8* getelementptr inbounds ([5 x i8]* @.passstr, i64 0, i64 0)) nounwind + ret i32 0 + +bbfalse: + %1 = call i32 @puts(i8* getelementptr inbounds ([5 x i8]* @.failstr, i64 0, i64 0)) nounwind + ret i32 0 +} -- cgit 1.4.1