From 380ca8863db645f0c00843af2fef575b655783ff Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Sun, 14 Jun 2009 04:23:54 +0000 Subject: Add several ConstantExpr utility functions and move clients over. - Reducing uses of getConstantValue() so we can move to arbitrary precision constants. - No (intended) functionality change. git-svn-id: https://llvm.org/svn/llvm-project/klee/trunk@73324 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Solver/CexCachingSolver.cpp | 6 +++--- lib/Solver/STPBuilder.cpp | 11 +++++------ lib/Solver/Solver.cpp | 4 ++-- 3 files changed, 10 insertions(+), 11 deletions(-) (limited to 'lib/Solver') diff --git a/lib/Solver/CexCachingSolver.cpp b/lib/Solver/CexCachingSolver.cpp index 9c233530..373f42d9 100644 --- a/lib/Solver/CexCachingSolver.cpp +++ b/lib/Solver/CexCachingSolver.cpp @@ -139,7 +139,7 @@ bool CexCachingSolver::lookupAssignment(const Query &query, KeyType key(query.constraints.begin(), query.constraints.end()); ref neg = Expr::createNot(query.expr); if (ConstantExpr *CE = dyn_cast(neg)) { - if (!CE->getConstantValue()) { + if (CE->isFalse()) { result = (Assignment*) 0; return true; } @@ -154,7 +154,7 @@ bool CexCachingSolver::getAssignment(const Query& query, Assignment *&result) { KeyType key(query.constraints.begin(), query.constraints.end()); ref neg = Expr::createNot(query.expr); if (ConstantExpr *CE = dyn_cast(neg)) { - if (!CE->getConstantValue()) { + if (CE->isFalse()) { result = (Assignment*) 0; return true; } @@ -220,7 +220,7 @@ bool CexCachingSolver::computeValidity(const Query& query, assert(isa(q) && "assignment evaluation did not result in constant"); - if (cast(q)->getConstantValue()) { + if (cast(q)->isTrue()) { if (!getAssignment(query, a)) return false; result = !a ? Solver::True : Solver::Unknown; diff --git a/lib/Solver/STPBuilder.cpp b/lib/Solver/STPBuilder.cpp index ab65f254..8680d0a8 100644 --- a/lib/Solver/STPBuilder.cpp +++ b/lib/Solver/STPBuilder.cpp @@ -608,11 +608,10 @@ ExprHandle STPBuilder::constructActual(ref e, int *width_out) { assert(*width_out!=1 && "uncanonicalized sdiv"); if (ConstantExpr *CE = dyn_cast(de->right)) { - uint64_t divisor = CE->getConstantValue(); - if (optimizeDivides) { if (*width_out == 32) //only works for 32-bit division - return constructSDivByConstant( left, *width_out, divisor); + return constructSDivByConstant( left, *width_out, + CE->getConstantValue()); } } @@ -776,9 +775,9 @@ ExprHandle STPBuilder::constructActual(ref e, int *width_out) { ExprHandle left = construct(ee->left, width_out); ExprHandle right = construct(ee->right, width_out); if (*width_out==1) { - if (isa(ee->left)) { - assert(!cast(ee->left)->getConstantValue() && - "uncanonicalized eq"); + if (ConstantExpr *CE = dyn_cast(ee->left)) { + if (CE->isTrue()) + return right; return vc_notExpr(vc, right); } else { return vc_iffExpr(vc, left, right); diff --git a/lib/Solver/Solver.cpp b/lib/Solver/Solver.cpp index 7a1b356c..9e8e37bf 100644 --- a/lib/Solver/Solver.cpp +++ b/lib/Solver/Solver.cpp @@ -57,7 +57,7 @@ bool Solver::evaluate(const Query& query, Validity &result) { // Maintain invariants implementations expect. if (ConstantExpr *CE = dyn_cast(query.expr)) { - result = CE->getConstantValue() ? True : False; + result = CE->isTrue() ? True : False; return true; } @@ -83,7 +83,7 @@ bool Solver::mustBeTrue(const Query& query, bool &result) { // Maintain invariants implementations expect. if (ConstantExpr *CE = dyn_cast(query.expr)) { - result = CE->getConstantValue() ? true : false; + result = CE->isTrue() ? true : false; return true; } -- cgit 1.4.1