From bc7ddafc93f1b30fa39e7f47f62b41ae3ed6a07b Mon Sep 17 00:00:00 2001 From: Paul Marinescu Date: Mon, 8 Dec 2014 01:07:52 +0000 Subject: Fix overshift check Shifting by bitwidth-1 is valid --- lib/Solver/MetaSMTBuilder.h | 2 +- lib/Solver/STPBuilder.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/Solver') diff --git a/lib/Solver/MetaSMTBuilder.h b/lib/Solver/MetaSMTBuilder.h index b5c99907..92b26926 100644 --- a/lib/Solver/MetaSMTBuilder.h +++ b/lib/Solver/MetaSMTBuilder.h @@ -284,7 +284,7 @@ typename SolverContext::result_type MetaSMTBuilder::constructAShr if (shift == 0) { res = expr; } - else if (shift >= width - 1) { + else if (shift >= width) { res = evaluate(_solver, metaSMT::logic::Ite(isSigned, bvMinusOne(width), bvZero(width))); } else { diff --git a/lib/Solver/STPBuilder.cpp b/lib/Solver/STPBuilder.cpp index 34ce0ede..6d7dd8b7 100644 --- a/lib/Solver/STPBuilder.cpp +++ b/lib/Solver/STPBuilder.cpp @@ -283,7 +283,7 @@ ExprHandle STPBuilder::constructAShrByConstant(ExprHandle expr, if (shift==0) { return expr; - } else if (shift>=width-1) { + } else if (shift>=width) { return bvZero(width); // Overshift to zero } else { return vc_iteExpr(vc, -- cgit 1.4.1