From 45ab1e5aa339c350e3efbbc9ad7abdfc22e73187 Mon Sep 17 00:00:00 2001 From: Quentin Carbonneaux Date: Sun, 20 Nov 2022 21:47:11 +0100 Subject: stored bytes in Alias information Stack slots may have padding bytes, and if we want to have precise liveness information it's important that we are able to tell them apart. This patch extends fillalias() to remember for every slot what bytes were ever assigned. In case the slot address does not escape we know that only these bytes matter. To save space, we only store this information if the slot size is less than or equal to NBit. The Alias struct was reworked a bit to save some space. I am still not very satisfied with its layout though. --- alias.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) (limited to 'alias.c') diff --git a/alias.c b/alias.c index 44686dd..fd11bd2 100644 --- a/alias.c +++ b/alias.c @@ -18,8 +18,8 @@ getalias(Alias *a, Ref r, Fn *fn) c = &fn->con[r.val]; if (c->type == CAddr) { a->type = ASym; - a->label = c->label; - a->reloc = c->reloc; + a->u.sym.label = c->label; + a->u.sym.con = r.val; } else a->type = ACon; a->offset = c->bits.i; @@ -52,7 +52,7 @@ alias(Ref p, int sp, Ref q, int sq, int *delta, Fn *fn) /* they conservatively alias if the * symbols are different, or they * alias for sure if they overlap */ - if (ap.label != aq.label) + if (ap.u.sym.label != aq.u.sym.label) return MayAlias; if (ovlap) return MustAlias; @@ -108,9 +108,12 @@ void fillalias(Fn *fn) { uint n, m; + int64_t x; + bits w; Blk *b; Phi *p; Ins *i; + Con *c; Alias *a, a0, a1; for (n=0; nnblk; ++n) { @@ -135,6 +138,14 @@ fillalias(Fn *fn) if (Oalloc <= i->op && i->op <= Oalloc1) { a->type = ALoc; a->slot = a; + a->u.loc.sz = -1; + if (rtype(i->arg[0]) == RCon) { + c = &fn->con[i->arg[0].val]; + x = c->bits.i; + if (c->type == CBits) + if (0 <= x && x <= NBit) + a->u.loc.sz = x; + } } else { a->type = AUnk; a->slot = 0; @@ -165,6 +176,19 @@ fillalias(Fn *fn) if (i->op != Oargc) esc(i->arg[1], fn); } + if (isstore(i->op)) + if (rtype(i->arg[1]) == RTmp) { + a = &fn->tmp[i->arg[1].val].alias; + if (a->slot) { + assert(astack(a->type)); + x = a->offset; + if (0 <= x && x < NBit) { + w = BIT(storesz(i)) - 1; + a->slot->u.loc.m |= w << x; + } else + a->slot->u.loc.sz = -1; + } + } } esc(b->jmp.arg, fn); } -- cgit 1.4.1