about summary refs log tree commit diff
diff options
context:
space:
mode:
authorhexcoder- <heiko@hexco.de>2020-08-13 15:44:03 +0200
committerhexcoder- <heiko@hexco.de>2020-08-13 15:44:03 +0200
commit47faf3dd33bb2335702fcbb67b3a64650c4344b3 (patch)
tree88e3980d3478ac3d210af2a11dbdcff740f64560
parentc4e52e20c9fa41b95e110d288bc96939e5625761 (diff)
downloadafl++-47faf3dd33bb2335702fcbb67b3a64650c4344b3.tar.gz
code review: fixed some typos
-rw-r--r--llvm_mode/README.instrument_list.md18
-rw-r--r--llvm_mode/afl-llvm-common.cc12
-rw-r--r--llvm_mode/afl-llvm-rt.o.c4
3 files changed, 17 insertions, 17 deletions
diff --git a/llvm_mode/README.instrument_list.md b/llvm_mode/README.instrument_list.md
index d4739dda..1fc06414 100644
--- a/llvm_mode/README.instrument_list.md
+++ b/llvm_mode/README.instrument_list.md
@@ -14,13 +14,13 @@ disturbance by uninteresting code being exercised.
 
 For this purpose, a "partial instrumentation" support en par with llvm sancov
 is provided by afl++ that allows you to specify on a source file and function
-level which should be compiled with or without instrumentation.
+level which function should be compiled with or without instrumentation.
 
 Note: When using PCGUARD mode - and have llvm 12+ - you can use this instead:
 https://clang.llvm.org/docs/SanitizerCoverage.html#partially-disabling-instrumentation
 
-the llvm sancov list format is fully supported by afl++, however afl++ has
-more flexbility.
+The llvm sancov list format is fully supported by afl++, however afl++ has
+more flexibility.
 
 ## 2) Building the LLVM module
 
@@ -35,13 +35,13 @@ The only required change is that you need to set either the environment variable
 AFL_LLVM_ALLOWLIST or AFL_LLVM_DENYLIST set with a filename.
 
 That file then contains the filenames or functions that should be instrumented
-(AFL_LLVM_ALLOWLIST) or should specifically NOT instrumentd (AFL_LLVM_DENYLIST).
+(AFL_LLVM_ALLOWLIST) or should specifically NOT be instrumented (AFL_LLVM_DENYLIST).
 
 For matching, the function/filename that is being compiled must end in the
-function/filename entry contained in this the instrument file list (to avoid
+function/filename entry contained in this instrument file list (to avoid
 breaking the matching when absolute paths are used during compilation).
 
-**NOTE:** In optimization functions might be inlined and then not match!
+**NOTE:** In builds with optimization enabled functions might be inlined and would not match!
 
 For example if your source tree looks like this:
 ```
@@ -52,7 +52,7 @@ project/feature_b/b1.cpp
 project/feature_b/b2.cpp
 ```
 
-and you only want to test feature_a, then create a the instrument file list file containing:
+and you only want to test feature_a, then create a instrument file list file containing:
 ```
 feature_a/a1.cpp
 feature_a/a2.cpp
@@ -69,7 +69,7 @@ exists somewhere else in the project directories.
 You can also specify function names. Note that for C++ the function names
 must be mangled to match!
 
-afl++ is intelligent to identify if an entry is a filename or a function.
+afl++ is able to identify if an entry is a filename or a function.
 However if you want to be sure (and compliant to the sancov allow/blocklist
 format), you can specify source file entries like this:
 ```
@@ -79,7 +79,7 @@ and function entries like this:
 ```
 fun: MallocFoo
 ```
-Note that whitespace is ignored and comments (`# foo`) supported.
+Note that whitespace is ignored and comments (`# foo`) are supported.
 
 ## 4) UNIX-style pattern matching
 You can add UNIX-style pattern matching in the the instrument file list entries.
diff --git a/llvm_mode/afl-llvm-common.cc b/llvm_mode/afl-llvm-common.cc
index f12bbe31..7a73a174 100644
--- a/llvm_mode/afl-llvm-common.cc
+++ b/llvm_mode/afl-llvm-common.cc
@@ -331,8 +331,8 @@ bool isInInstrumentList(llvm::Function *F) {
 
   bool return_default = true;
 
-  // is this a function with code? If it is external we dont instrument it
-  // anyway and cant be in the the instrument file list. Or if it is ignored.
+  // is this a function with code? If it is external we don't instrument it
+  // anyway and it can't be in the instrument file list. Or if it is it is ignored.
   if (!F->size() || isIgnoreFunction(F)) return false;
 
   if (!denyListFiles.empty() || !denyListFunctions.empty()) {
@@ -476,7 +476,7 @@ bool isInInstrumentList(llvm::Function *F) {
       else {
 
         // we could not find out the location. in this case we say it is not
-        // in the the instrument file list
+        // in the instrument file list
         if (!be_quiet)
           WARNF(
               "No debug information found for function %s, will be "
@@ -489,7 +489,7 @@ bool isInInstrumentList(llvm::Function *F) {
 
   }
 
-  // if we do not have a the instrument file list return true
+  // if we do not have a instrument file list return true
   if (!allowListFiles.empty() || !allowListFunctions.empty()) {
 
     return_default = false;
@@ -632,8 +632,8 @@ bool isInInstrumentList(llvm::Function *F) {
 #endif
       else {
 
-        // we could not find out the location. in this case we say it is not
-        // in the the instrument file list
+        // we could not find out the location. In this case we say it is not
+        // in the instrument file list
         if (!be_quiet)
           WARNF(
               "No debug information found for function %s, will not be "
diff --git a/llvm_mode/afl-llvm-rt.o.c b/llvm_mode/afl-llvm-rt.o.c
index dacc46a6..78e1c160 100644
--- a/llvm_mode/afl-llvm-rt.o.c
+++ b/llvm_mode/afl-llvm-rt.o.c
@@ -853,7 +853,7 @@ void __afl_manual_init(void) {
 
     if (getenv("AFL_DEBUG"))
       fprintf(stderr,
-              "DEBUG: disabled instrumenation because of "
+              "DEBUG: disabled instrumentation because of "
               "AFL_DISABLE_LLVM_INSTRUMENTATION\n");
 
   }
@@ -901,7 +901,7 @@ __attribute__((constructor(0))) void __afl_auto_early(void) {
 void __sanitizer_cov_trace_pc_guard(uint32_t *guard) {
 
   // For stability analysis, if you want to know to which function unstable
-  // edge IDs belong to - uncomment, recompile+install llvm_mode, recompile
+  // edge IDs belong - uncomment, recompile+install llvm_mode, recompile
   // the target. libunwind and libbacktrace are better solutions.
   // Set AFL_DEBUG_CHILD_OUTPUT=1 and run afl-fuzz with 2>file to capture
   // the backtrace output