diff options
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/helper.cr | 11 | ||||
| -rw-r--r-- | spec/server_spec.cr (renamed from spec/server.cr) | 50 |
2 files changed, 33 insertions, 28 deletions
diff --git a/spec/helper.cr b/spec/helper.cr index 6fe13e5..01f2f95 100644 --- a/spec/helper.cr +++ b/spec/helper.cr @@ -21,9 +21,12 @@ require "spec" require "../src/cli" -CONFIG = Configuration.new({"general" => {"db" => File.tempname, - "api" => "/"}, +CONFIG = Configuration.new({"general" => {"sock" => File.tempname, + "db" => File.tempname, + "css" => "eg/style.css"}, "opennic" => {"local" => File.tempname, - "remote" => "http://example.null"}, + "remote" => "http://example.null/", + "api" => ""}, "icann" => {"local" => File.tempname, - "remote" => "http://example.net"}}) + "remote" => "http://example.net/", + "api" => ""}}) diff --git a/spec/server.cr b/spec/server_spec.cr index d24fe1d..ab9e1c8 100644 --- a/spec/server.cr +++ b/spec/server_spec.cr @@ -18,6 +18,7 @@ require "file_utils" require "http/client" +require "socket" require "./helper" require "../src/http" @@ -28,9 +29,9 @@ BASE_DATA = {"nick" => "example", "icann" => "https://example.org", "host" => "example.net"} -def expect_errors(url, overlay, expected) +def expect_errors(client, overlay, expected) data = BASE_DATA.merge overlay - response = HTTP::Client.post url, form: URI::Params.encode data + response = client.post "/", form: URI::Params.encode data response.status_code.should eq 400 response.content_type.should eq "application/xhtml+xml" xml = XML.parse response.body @@ -42,17 +43,16 @@ def expect_errors(url, overlay, expected) errors.should eq expected end -url = uninitialized String +client = uninitialized HTTP::Client Spec.before_suite do server = Server.new CONFIG spawn do - server.listen do |address| - url = "http://#{address}" - end + server.listen do end end until server.listening? sleep 1.milliseconds end + client = HTTP::Client.new UNIXSocket.new CONFIG.sock Spec.after_suite do server.close FileUtils.rm_r [CONFIG.db, CONFIG.opennic_local, CONFIG.icann_local] @@ -60,9 +60,10 @@ Spec.before_suite do end describe Server do - it "only accepts POST requests" do + pending "only accepts POST requests" do %w(GET PUT HEAD DELETE PATCH OPTIONS).each do |method| - response = HTTP::Client.exec method, url + # FIXME: Unsupported HTTP version: 405 (Exception)??? + response = client.exec method, "/" response.status_code.should eq 405 end end @@ -71,24 +72,25 @@ describe Server do # FIXME: HTTP::Client automatically sets the header based on body end - it "rejects too long content" do - response = HTTP::Client.post url, body: "x" * (MAX_CONTENT_LENGTH + 1) + pending "rejects too long content" do + # FIXME: Race condition in HTTP::Client + response = client.post "/", body: "x" * (MAX_CONTENT_LENGTH + 1) response.status_code.should eq 413 end it "only accepts application/x-www-form-urlencoded Content-Type" do - response = HTTP::Client.post url + response = client.post "/" response.status_code.should eq 415 %w(multipart/form-data text/html text/plain).each do |content_type| headers = HTTP::Headers{"Content-Type" => content_type} - response = HTTP::Client.post url, headers + response = client.post "/", headers response.status_code.should eq 415 end end it "only allows parameters nick, opennic, icann or host" do data = BASE_DATA.merge Hash{"foo" => "bar"} - response = HTTP::Client.post url, form: URI::Params.encode data + response = client.post "/", form: URI::Params.encode data response.status_code.should eq 400 response.content_type.should eq "text/plain" response.body.should eq "400 Invalid Parameter\n" @@ -99,7 +101,7 @@ describe Server do until k = 0 keys.combinations(k).each do |c| data = BASE_DATA.reject c - response = HTTP::Client.post url, form: URI::Params.encode data + response = client.post "/", form: URI::Params.encode data response.status_code.should eq 400 response.content_type.should eq "text/plain" response.body.should eq "400 Missing Parameter\n" @@ -110,36 +112,36 @@ describe Server do it "rejects too long nick" do msg = "Must be within #{MAX_NICK_LENGTH} characters" - expect_errors url, {"nick" => "x" * (MAX_NICK_LENGTH + 1)}, + expect_errors client, {"nick" => "x" * (MAX_NICK_LENGTH + 1)}, {"nick" => "Must match #{NICK_PATTERN}"} end it "rejects nicks that are not lowercase alphanumeric" do %w(camelCase pun/tu?a#tion).each do |nick| - expect_errors url, {"nick" => nick}, + expect_errors client, {"nick" => nick}, {"nick" => "Must match #{NICK_PATTERN}"} end end it "rejects relative URLs" do %w(foo /bar ex.am/ple).each do |uri| - expect_errors url, {"opennic" => uri, "icann" => uri}, + expect_errors client, {"opennic" => uri, "icann" => uri}, {"opennic" => "Must be absolute URL", "icann" => "Must be absolute URL"} end end it "only accepts HTTP/S" do - expect_errors url, {"opennic" => "gopher://example.indy"}, + expect_errors client, {"opennic" => "gopher://example.indy"}, {"opennic" => "Must be HTTP/S"} - expect_errors url, {"opennic" => "https://example.indy", + expect_errors client, {"opennic" => "https://example.indy", "icann" => "http://example.org"}, {"icann" => "Must be HTTPS"} end it "checks for OpenNIC domain" do - expect_errors url, {"opennic" => "http://example.org", - "icann" => "https://example.indy"}, + expect_errors client, {"opennic" => "http://example.org", + "icann" => "https://example.indy"}, {"opennic" => "Must be under OpenNIC domain", "icann" => "Must not be under OpenNIC domain"} end @@ -153,7 +155,7 @@ describe Server do keys.combinations(k).each do |c| errors = base_errors.select c data = BASE_DATA.merge overlay.select errors.keys - expect_errors url, data, errors + expect_errors client, data, errors k -= 1 end end @@ -162,7 +164,7 @@ describe Server do it "prevents nick from colliding with HTML headings' id" do msg = "Reserved names: #{HTML_HEADINGS.join ", "}" HTML_HEADINGS.each do |nick| - expect_errors url, {"nick" => nick}, {"nick" => msg} + expect_errors client, {"nick" => nick}, {"nick" => msg} end end @@ -170,7 +172,7 @@ describe Server do overlay = {"nick" => "chad", "opennic" => "http://chad.epic", "icann" => "https://chad.example"} data = BASE_DATA.merge overlay - response = HTTP::Client.post url, form: URI::Params.encode data + response = client.post "/", form: URI::Params.encode data response.status_code.should eq 200 response.content_type.should eq "application/xhtml+xml" db = Database.new CONFIG.db |