about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDongjia "toka" Zhang <tokazerkje@outlook.com>2023-06-24 00:21:45 +0200
committerGitHub <noreply@github.com>2023-06-24 00:21:45 +0200
commit0616f368c83189ef5559f64d2053129d329aaefe (patch)
tree0cc7c0551424733f8add27741a22c6a65711406f
parentaf8c68a774d0271ae6a2145ac566e1c7024e95d5 (diff)
downloadafl++-0616f368c83189ef5559f64d2053129d329aaefe.tar.gz
fixing laf
-rw-r--r--instrumentation/split-compares-pass.so.cc15
1 files changed, 10 insertions, 5 deletions
diff --git a/instrumentation/split-compares-pass.so.cc b/instrumentation/split-compares-pass.so.cc
index aec6758e..3cfd1964 100644
--- a/instrumentation/split-compares-pass.so.cc
+++ b/instrumentation/split-compares-pass.so.cc
@@ -463,8 +463,9 @@ bool SplitComparesTransform::simplifyOrEqualsCompare(CmpInst     *IcmpInst,
 #else
   ReplaceInstWithInst(IcmpInst->getParent()->getInstList(), ii, PN);
 #endif
-
-  worklist.push_back(icmp_np);
+  if (new_pred == CmpInst::ICMP_SGT || new_pred == CmpInst::ICMP_SLT) {
+    simplifySignedCompare(icmp_np, M, worklist);
+  }
   worklist.push_back(icmp_eq);
 
   return true;
@@ -740,18 +741,22 @@ bool SplitComparesTransform::splitCompare(CmpInst *cmp_inst, Module &M,
       CmpInst     *icmp_inv_cmp = nullptr;
       BasicBlock  *inv_cmp_bb =
           BasicBlock::Create(C, "inv_cmp", end_bb->getParent(), end_bb);
-      if (pred == CmpInst::ICMP_UGT || pred == CmpInst::ICMP_SGT ||
-          pred == CmpInst::ICMP_UGE || pred == CmpInst::ICMP_SGE) {
+      if (pred == CmpInst::ICMP_UGT) {
 
         icmp_inv_cmp = CmpInst::Create(Instruction::ICmp, CmpInst::ICMP_ULT,
                                        op0_high, op1_high);
 
-      } else {
+      } else if (pred == CmpInst::ICMP_ULT) {
 
         icmp_inv_cmp = CmpInst::Create(Instruction::ICmp, CmpInst::ICMP_UGT,
                                        op0_high, op1_high);
 
       }
+      else {
+        // Never gonna appen
+        if (!be_quiet)
+          fprintf(stderr, "Error: split-compare: Equals or signed not removed: %d\n", pred);
+      }
 
 #if LLVM_MAJOR >= 16
       icmp_inv_cmp->insertInto(inv_cmp_bb, inv_cmp_bb->end());