about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorRick van Schijndel <rol3517@gmail.com>2020-04-23 23:16:13 +0200
committerRick van Schijndel <rol3517@gmail.com>2020-04-23 23:21:38 +0200
commit82b6b8c87e1bc5394349fd2931b306f671c4da1a (patch)
treee412a9c3aa0b952402d38d1487d22fdb3f1e69eb /src
parentb6f9f4c436bc8c63f9039847d2a7b6e13da3515e (diff)
downloadafl++-82b6b8c87e1bc5394349fd2931b306f671c4da1a.tar.gz
afl-gcc and afl-clang: fail when binary name can't be used to determine build mode
This is a continuation of PR #318.
The goal is to prevent issues where binaries with the wrong name will
silently pass control to the C compiler instead of failing.
This makes it more explicit that aflplusplus relies on the name of the
binary for correct compiler execution.
Diffstat (limited to 'src')
-rw-r--r--src/afl-gcc.c27
1 files changed, 22 insertions, 5 deletions
diff --git a/src/afl-gcc.c b/src/afl-gcc.c
index 6c6bd1f1..ac6fdd62 100644
--- a/src/afl-gcc.c
+++ b/src/afl-gcc.c
@@ -149,11 +149,17 @@ static void edit_params(u32 argc, char **argv) {
       u8 *alt_cxx = getenv("AFL_CXX");
       cc_params[0] = alt_cxx && *alt_cxx ? alt_cxx : (u8 *)"clang++";
 
-    } else {
+    } else if (!strcmp(name, "afl-clang")) {
 
       u8 *alt_cc = getenv("AFL_CC");
       cc_params[0] = alt_cc && *alt_cc ? alt_cc : (u8 *)"clang";
 
+    } else {
+
+      fprintf(stderr, "Name of the binary: %s\n", argv[0]);
+      FATAL(
+        "Name of the binary is not a known name, expected afl-clang(++)");
+
     }
 
   } else {
@@ -166,12 +172,17 @@ static void edit_params(u32 argc, char **argv) {
 
 #ifdef __APPLE__
 
-    if (!strcmp(name, "afl-g++"))
+    if (!strcmp(name, "afl-g++")) {
       cc_params[0] = getenv("AFL_CXX");
-    else if (!strcmp(name, "afl-gcj"))
+    } else if (!strcmp(name, "afl-gcj")) {
       cc_params[0] = getenv("AFL_GCJ");
-    else
+    } else if (!strcmp(name, "afl-gcc")) {
       cc_params[0] = getenv("AFL_CC");
+    } else {
+      fprintf(stderr, "Name of the binary: %s\n", argv[0]);
+      FATAL(
+        "Name of the binary is not a known name, expected afl-gcc/g++/gcj");
+    }
 
     if (!cc_params[0]) {
 
@@ -199,11 +210,17 @@ static void edit_params(u32 argc, char **argv) {
       u8 *alt_cc = getenv("AFL_GCJ");
       cc_params[0] = alt_cc && *alt_cc ? alt_cc : (u8 *)"gcj";
 
-    } else {
+    } else if (!strcmp(name, "afl-gcc")) {
 
       u8 *alt_cc = getenv("AFL_CC");
       cc_params[0] = alt_cc && *alt_cc ? alt_cc : (u8 *)"gcc";
 
+    } else {
+
+      fprintf(stderr, "Name of the binary: %s\n", argv[0]);
+      FATAL(
+        "Name of the binary is not a known name, expected afl-gcc/g++/gcj");
+
     }
 
 #endif                                                         /* __APPLE__ */