summary refs log tree commit diff
diff options
context:
space:
mode:
authorMaxim Cournoyer <maxim.cournoyer@gmail.com>2020-04-15 02:03:26 -0400
committerMaxim Cournoyer <maxim.cournoyer@gmail.com>2020-04-15 02:03:26 -0400
commita4f1a7e2db22cd028fb514846c2791928b8734d3 (patch)
tree9f145d693d535fa8dc48e407ab3a3486aced365f
parent109bf6a0e7111a75a54924be8a58c0fbc9a55c7d (diff)
downloadguix-a4f1a7e2db22cd028fb514846c2791928b8734d3.tar.gz
gnu: linphoneqt: Fix reproducibility issue and improve description.
* gnu/packages/linphone.scm (linphoneqt)[phases]: Rename the 'patch phase to
'set-version-string, and use the version variable of the package in the
replacement.
{set-qt-rcc-source-date-override, fix-cmake-error}: Add phases.
[synopsis]: Explicit what the package is.
[description]: Mention more useful keywords and features.
-rw-r--r--gnu/packages/linphone.scm42
1 files changed, 35 insertions, 7 deletions
diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
index 6278dcaba7..e18d04bd06 100644
--- a/gnu/packages/linphone.scm
+++ b/gnu/packages/linphone.scm
@@ -488,13 +488,27 @@ and video calls or instant messaging capabilities to an application.")
     (arguments
      `(#:tests? #f                      ; No test target
        #:phases
-       ;; For replacing undeclared variable.
        (modify-phases %standard-phases
-         (add-after 'unpack 'patch
+         (add-after 'set-paths 'set-qt-rcc-source-date-override
+           (lambda _
+             ;; This fixes a reproducibility problem where the Qt Resource
+             ;; Compiler (RCC) includes timestamp of the its source files
+             ;; (see: https://reproducible-builds.org/docs/
+             ;;       deterministic-build-systems/#cmake-notes)
+             (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1")
+             #t))
+         (add-after 'unpack 'fix-cmake-error
+           (lambda _
+             ;; This is fixed in commit efed2fd8 of the master branch.
+             (substitute* "CMakeLists.txt"
+               (("js)\\$\"")
+                "js$\""))
+             #t))
+         (add-after 'unpack 'set-version-string
            (lambda _
              (substitute* "src/app/AppController.cpp"
                (("LINPHONE_QT_GIT_VERSION")
-                "\"4.1.1\""))
+                (format #f "~s" ,version)))
              #t)))))
     (native-inputs
      `(("qttools" ,qttools)))
@@ -509,10 +523,24 @@ and video calls or instant messaging capabilities to an application.")
        ("qtgraphicaleffects" ,qtgraphicaleffects)
        ("qtquickcontrols2" ,qtquickcontrols2)
        ("qtsvg" ,qtsvg)))
-    (synopsis "Belledonne Communications Softphone Application")
-    (description "Linphone is a softphone for voice and video over IP calling
-and instant messaging.  It is fully SIP-based, for all calling, presence
-and IM features.")
+    (synopsis "Desktop client for the Linphone SIP softphone")
+    (description "Linphone is a SIP softphone for voice and video over IP calling
+(VoIP) and instant messaging.  Amongst its features are:
+@itemize
+@item High Definition (HD) audio and video calls
+@item Multiple call management (pause and resume)
+@item Call transfer
+@item Audio conferencing (merge calls into a conference call)
+@item Call recording and replay (audio only)
+@item Instant Messaging with message delivery status (IMDN)
+@item Picture and file sharing
+@item Echo cancellation
+@item Secure user authentication using TLS client certificates
+@item SRTP, zRTP and SRTP-DTLS voice and video encryption
+@item Telephone tone (DTMF) support using SIP INFO or RFC 4733
+@item Audio codecs: opus, speex, g711, g729, gsm, iLBC, g722, SILK, etc.
+@item Video codecs: VP8, H.264 and H.265 with resolutions up to 1080P, MPEG4
+@end itemize")
     (home-page "https://gitlab.linphone.org/BC/public/linphone-desktop")
     (license license:gpl2+)))