about summary refs log tree commit diff homepage
diff options
context:
space:
mode:
authorCristian Cadar <c.cadar@imperial.ac.uk>2020-12-30 21:32:20 +0000
committerMartinNowack <2443641+MartinNowack@users.noreply.github.com>2021-02-26 14:26:38 +0000
commit295353010d23c9561826f811a59b7d5556c45596 (patch)
treeec0dd3606f9c3c05fb24199ce700091026c21248
parent148a68df793fca84a36fefd8824ea54fdf6583f4 (diff)
downloadklee-295353010d23c9561826f811a59b7d5556c45596.tar.gz
Improved PR template by making it more succinct.
-rw-r--r--.github/pull_request_template.md24
1 files changed, 15 insertions, 9 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 86cf67e9..9e2941ea 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -1,12 +1,18 @@
-Thank you for contributing to KLEE.  We are looking forward to reviewing your PR.  However, given the small number of active reviewers and our limited time, it might take a while to do so.  We aim to get back to each PR within one month, and often do so within one week. 
+<!--
+Thank you for contributing to KLEE. We are looking forward to reviewing your PR. However, given the small number of active reviewers and our limited time, it might take a while to do so. We aim to get back to each PR within one month, and often do so within one week.
 
-To help expedite the review please ensure the following, by adding an "x" for each completed item:
+To review your PR, please add a summary of the proposed changes and ensure all items are fulfilled in the checklist above, by placing an "x" inside each applicable pair of brackets. More details about each item can be found in the [Developer's Guide](https://klee.github.io/docs/developers-guide/#pull-requests).
+-->
 
-- [ ] The PR addresses a single issue.  In other words, if some parts of a PR could form another independent PR, you should break this PR into multiple smaller PRs.
-- [ ] There are no unnecessary commits. For instance, commits that fix issues with a previous commit in this PR are unnecessary and should be removed (you can find [documentation on squashing commits here](https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#squash-your-changes)).
-- [ ] Larger PRs are divided into a logical sequence of commits.
+## Summary: 
+
+
+## Checklist:
+- [ ] The PR addresses a single issue.  If it can be divided into multiple independent PRs, please do so.
+- [ ] The PR is divided into a logical sequence of commits OR a single commit is sufficient.
+- [ ] There are no unnecessary commits (e.g. commits fixing issues in a previous commit in the same PR).
 - [ ] Each commit has a meaningful message documenting what it does.
-- [ ] The code is commented.  In particular, newly added classes and functions should be documented.
-- [ ] The patch is formatted via  [clang-format](https://clang.llvm.org/docs/ClangFormat.html) (see also [git-clang-format](https://raw.githubusercontent.com/llvm/llvm-project/master/clang/tools/clang-format/git-clang-format) for Git integration).  Please only format the patch itself and code surrounding the patch, not entire files.  Divergences from clang-formatting are only rarely accepted, and only if they clearly improve code readability.
-- [ ] Add test cases exercising the code you added or modified.  We expect [system and/or unit test cases](https://klee.github.io/docs/developers-guide/#regression-testing-framework) for all non-trivial changes.  After you submit your PR, you will be able to see a [Codecov report](https://docs.codecov.io/docs/pull-request-comments) telling you which parts of your patch are not covered by the regression test suite.  You will also be able to see if the Github Actions CI and Cirrus CI tests have passed.  If they don't, you should examine the failures and address them before the PR can be reviewed. 
-- [ ] Spellcheck all messages added to the codebase, all comments, as well as commit messages.
+- [ ] All messages added to the codebase, all comments, as well as commit messages are spellchecked.
+- [ ] The code is commented OR not applicable/necessary.
+- [ ] The patch is formatted via clang-format OR not applicable (if explicitly overridden leave unchecked and explain).
+- [ ] There are test cases for the code you added or modified OR no such test cases are required.