about summary refs log tree commit diff homepage
path: root/unittests
diff options
context:
space:
mode:
authorJulian Büning <julian.buening@comsys.rwth-aachen.de>2023-04-01 13:22:38 +0200
committerCristian Cadar <c.cadar@imperial.ac.uk>2023-04-18 13:09:24 +0100
commitadfca64fdbcfd75d42b7a069d27ddbb0228e9eff (patch)
tree72fea41d16a28a10b14305fdf47af4cc3875a51a /unittests
parent02b52541c5e8262e7f7a909d90fb898399d822bd (diff)
downloadklee-adfca64fdbcfd75d42b7a069d27ddbb0228e9eff.tar.gz
change some obsolete KDAlloc comments
- mappings were only shared in a former version of KDAlloc
- `AllocationFactory(std::size_t, std::uint32_t)`'s second parameter is
  used for quarantine size, not the location of the mapping
Diffstat (limited to 'unittests')
-rw-r--r--unittests/KDAlloc/allocate.cpp3
-rw-r--r--unittests/KDAlloc/rusage.cpp6
-rw-r--r--unittests/KDAlloc/sample.cpp3
3 files changed, 4 insertions, 8 deletions
diff --git a/unittests/KDAlloc/allocate.cpp b/unittests/KDAlloc/allocate.cpp
index 895f8215..c691e114 100644
--- a/unittests/KDAlloc/allocate.cpp
+++ b/unittests/KDAlloc/allocate.cpp
@@ -23,8 +23,7 @@ int allocate_sample_test() {
 #else
 int main() {
 #endif
-  // initialize a factory and an associated allocator (using the location "0"
-  // gives an OS-assigned location)
+  // initialize a factory and an associated allocator (1 MiB and no quarantine)
   klee::kdalloc::AllocatorFactory factory(static_cast<std::size_t>(1) << 20, 0);
   klee::kdalloc::Allocator allocator = factory.makeAllocator();
 
diff --git a/unittests/KDAlloc/rusage.cpp b/unittests/KDAlloc/rusage.cpp
index 453c5e5d..2a893d7d 100644
--- a/unittests/KDAlloc/rusage.cpp
+++ b/unittests/KDAlloc/rusage.cpp
@@ -35,10 +35,8 @@ std::size_t write_to_allocations(std::vector<void *> &allocations) {
 }
 
 TEST(KDAllocTest, Rusage) {
-  // initialize a factory and an associated allocator (using the location "0"
-  // gives an OS-assigned location)
-  klee::kdalloc::AllocatorFactory factory(static_cast<std::size_t>(1) << 30,
-                                          0); // 1 GB
+  // initialize a factory and an associated allocator (1 GiB and no quarantine)
+  klee::kdalloc::AllocatorFactory factory(static_cast<std::size_t>(1) << 30, 0);
   klee::kdalloc::Allocator allocator = factory.makeAllocator();
 
   std::vector<void *> allocations;
diff --git a/unittests/KDAlloc/sample.cpp b/unittests/KDAlloc/sample.cpp
index d4bed00b..365e7e21 100644
--- a/unittests/KDAlloc/sample.cpp
+++ b/unittests/KDAlloc/sample.cpp
@@ -20,8 +20,7 @@ int sample_test() {
 #else
 int main() {
 #endif
-  // initialize a factory and an associated allocator (using the location "0"
-  // gives an OS-assigned location)
+  // initialize a factory and an associated allocator (1 TiB and no quarantine)
   klee::kdalloc::AllocatorFactory factory(static_cast<std::size_t>(1) << 40, 0);
   klee::kdalloc::Allocator allocator = factory.makeAllocator();