diff options
| author | Quentin Carbonneaux <quentin@c9x.me> | 2021-07-28 00:29:50 +0200 |
|---|---|---|
| committer | Quentin Carbonneaux <quentin@c9x.me> | 2021-07-28 00:29:50 +0200 |
| commit | 7f4ab8d801edd1db8518ecd110c53483f847a8e9 (patch) | |
| tree | f647116048e12ea1c10d4378583b15bf8e4b67e4 | |
| parent | 6d9ee1389572ae985f6a39bb99dbd10cdf42c123 (diff) | |
| download | roux-7f4ab8d801edd1db8518ecd110c53483f847a8e9.tar.gz | |
fix amd64 addressing selection bug (afl)
Reported by Alessandro Mantovani.
Unlikely to be hit in practice
because we don't add addresses to
addresses.
type :biggie = { l, l, l }
function $repro(:biggie %p) {
@start
%x =l add %p, $a
storew 42, %x
ret
}
| -rw-r--r-- | amd64/emit.c | 1 | ||||
| -rw-r--r-- | amd64/isel.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/amd64/emit.c b/amd64/emit.c index d8b29bd..29b6bbb 100644 --- a/amd64/emit.c +++ b/amd64/emit.c @@ -184,6 +184,7 @@ regtoa(int reg, int sz) { static char buf[6]; + assert(reg <= XMM15); if (reg >= XMM0) { sprintf(buf, "xmm%d", reg-XMM0); return buf; diff --git a/amd64/isel.c b/amd64/isel.c index 5f84561..31199da 100644 --- a/amd64/isel.c +++ b/amd64/isel.c @@ -147,7 +147,7 @@ seladdr(Ref *r, ANum *an, Fn *fn) * rewrite it or bail out if * impossible */ - if (!req(a.index, R)) + if (!req(a.index, R) || rtype(a.base) != RTmp) return; else { a.index = a.base; |